Merged
Conversation
tonytrg
requested review from
SamMorrowDrums,
juruen,
toby and
williammartin
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds missing enum constraints for various string properties to ensure only the allowed values are accepted.
- Enforced enum constraints for pull request state, sort options, merge methods, and review event types in pkg/github/pullrequests.go.
- Added enum constraints for code scanning alert states and severity levels in pkg/github/code_scanning.go.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/github/pullrequests.go | Added enum constraints for pull request query and review parameters. |
| pkg/github/code_scanning.go | Added enum constraints for code scanning alerts parameters. |
tonytrg
force-pushed
the
tonytrg/add-constraints
branch
from
2928235 to
a92e445
Compare
tonytrg
force-pushed
the
tonytrg/add-constraints
branch
from
f810b65 to
5a7d13c
Compare
SamMorrowDrums
previously approved these changes
Apr 15, 2025
Collaborator
SamMorrowDrums
left a comment
SamMorrowDrums
left a comment
There was a problem hiding this comment.
Added one minor suggestion (the word category doesn't add much I think) but it's a nit, and this looks great. Thanks for all your work on finding all these!
nickytonline
pushed a commit
to nickytonline/github-mcp-http
that referenced
this pull request
Oct 4, 2025
* Add missing enum constraints * Remove redundant listing of additional enums in descriptions --------- Co-authored-by: Sam Morrow <info@sam-morrow.com>
DaleSeo
pushed a commit
to DaleSeo/github-mcp-server
that referenced
this pull request
Oct 24, 2025
Use config to mount kubernetes .kube/config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr adds some missing enum constraints for string props with enum like categories.
It also removes those listed enums from the descriptions, as the llm already receives the list of possible candidates by the the enum constraint.
This will save tokens as noted by @SamMorrowDrums
In regard to #228
Example testing with Copilot(Model Claude 3.7 Sonnet):